Skip to content

Add featutre flag for navigation state#3180

Merged
bidetofevil merged 1 commit intomainfrom
hho/nav-state-feature-flag
Apr 1, 2026
Merged

Add featutre flag for navigation state#3180
bidetofevil merged 1 commit intomainfrom
hho/nav-state-feature-flag

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Mar 31, 2026

Goal

Add remote feature flag to control the navigation state capture feature. The default is true because it should be on if the state feature is on

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.09%. Comparing base (6f2a899) to head (21f22d5).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3180      +/-   ##
==========================================
+ Coverage   77.97%   78.09%   +0.11%     
==========================================
  Files         558      556       -2     
  Lines       11970    11985      +15     
  Branches     1792     1789       -3     
==========================================
+ Hits         9334     9360      +26     
+ Misses       1924     1912      -12     
- Partials      712      713       +1     
Files with missing lines Coverage Δ
...nal/config/behavior/AutoDataCaptureBehaviorImpl.kt 90.47% <100.00%> (+0.47%) ⬆️
.../embracesdk/internal/config/remote/RemoteConfig.kt 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor Author

bidetofevil commented Apr 1, 2026

Merge activity

  • Apr 1, 2:48 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 1, 3:01 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 1, 3:02 PM UTC: @bidetofevil merged this pull request with Graphite.

@bidetofevil bidetofevil changed the base branch from hho/misc-race-fixes to graphite-base/3180 April 1, 2026 14:59
@bidetofevil bidetofevil changed the base branch from graphite-base/3180 to main April 1, 2026 15:00
@bidetofevil bidetofevil force-pushed the hho/nav-state-feature-flag branch from 58ce8e9 to 21f22d5 Compare April 1, 2026 15:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 21f22d5.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@bidetofevil bidetofevil merged commit 24f6c8c into main Apr 1, 2026
10 checks passed
@bidetofevil bidetofevil deleted the hho/nav-state-feature-flag branch April 1, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants